Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing relation type filter #191

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Add missing relation type filter #191

merged 2 commits into from
Jul 31, 2024

Conversation

das-Abroxas
Copy link
Contributor

This fixes a missing type filter in the SQL queries responsible for fetching a valid hierarchy of a resource.

@das-Abroxas das-Abroxas added the fix Bug issue fix label Jul 31, 2024
@das-Abroxas das-Abroxas requested a review from St4NNi July 31, 2024 12:09
@das-Abroxas das-Abroxas self-assigned this Jul 31, 2024
St4NNi
St4NNi previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Weird that this was not checked before, hopefully this will be superseded by the synevi upgrade.

@das-Abroxas das-Abroxas requested a review from St4NNi July 31, 2024 14:24
St4NNi
St4NNi approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets stay with Semver!

@das-Abroxas das-Abroxas merged commit efada09 into main Jul 31, 2024
5 checks passed
@das-Abroxas das-Abroxas deleted the fix/hierarchy-relation-filter branch July 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@St4NNi St4NNi St4NNi approved these changes

Assignees

@das-Abroxas das-Abroxas

Labels
fix Bug issue fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@das-Abroxas @St4NNi