Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MIRROR] Better UI for heretic research [MDB IGNORE] #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArkStation-Bot
Copy link
Collaborator

Original PR: NovaSector/NovaSector#3413

Original PR: tgstation/tgstation#84363

About The Pull Request

A redo of #82679. A new UI for heretic research that organizes the nodes into tiers and gives them icons.

This is done by a few new variables for the knowledge datum, which hold the level it should be located at, and the icon it should have. If not specified, an icon is automatically generated for summons, spells, eldritch marks and ascensions. You may also only specify some of the parameters, in which case the rest is generated automatically.

Also three notable related changes:

  • fixes a typo where the eldritch flask texture's state was called "eldrich_flask"
  • moves the code responsible for granting the ascension achievements into the parent path, the children simply hold a new variable to store the achievement to be granted. (apart from on its own being a good refactor, this also makes it possible to generate the ascension icons by taking the achievement sprites)
  • DmIcon now takes any type for the movement argument and casts it into boolean on its own, so that we can pass it BooleanLike

Screenshots:

image
image
image

Older design screenshots (for older comment context):

image
image
image

Why It's Good For The Game

Pretty UI is good. Makes the research interface less confusing by at least showing what nodes are more advanced, and will lead to ascension, and giving a rough idea of the relationship of the paths.

Changelog

馃啈
add: Added a new UI for heretic research.
/:cl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants