[MIRROR] [MIRROR] Gun Refactor Part 1: Bayonet Componentization [MDB IGNORE] #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#3483
Original PR: tgstation/tgstation#84246
About The Pull Request
The gun code is an absolute mess that seems to have been untouched for the better part of the decade and finally gave way due to the attack chain refactor. This PR is the first in my attempts to refactor this mess by making bayonet attachment a component instead of /obj/item/gun variables. Followup PRs may or may not be atomic changes or a monolith due to how horribly the original code is structured.
Why It's Good For The Game
Gun code is ancient, unmaintained, barely readable and started actively breaking in the past weeks.
Changelog
馃啈
refactor: Bayonet attachment is now a component.
/:cl: