Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MIRROR] Fixed quirk conflict between transhumanist and prosthetic limb [MDB IGNORE] #797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ArkStation-Bot
Copy link
Collaborator

Original PR: NovaSector/NovaSector#3517

Original PR: tgstation/tgstation#84325

About The Pull Request

Transhumanist and prosthetic limb no longer conflict. If you pick the same limb for both it uses the weaker prosthetic (dumbass)

Made the name for prosthetic limb global list more intelligible

Why It's Good For The Game

Transhumanist and prosthetic limb no longer conflict. If you pick the same limb for both it uses the weaker prosthetic (dumbass)

I wanted to RP a guy with a robotic voicebox and prosthetic limb but the game didn't let me, which I thought was pretty lame! Since the root issue is likely that both can have the same limb which ends up as Free Points as transhuman takes priority, I just added a check to ensure that can't happen and is overridden by the negative instead. Any transhumanist mood point benefits are made up for by the bad limb.

Made the name for prosthetic limb global list more intelligible

It was bad

Changelog

🆑
qol: Transhumanist and prosthetic limb no longer conflict. If you pick the same limb for both it uses the weaker prosthetic (dumbass)
code: Made the name for prosthetic limb global list more intelligible

/:cl:

NovaBot13 and others added 2 commits July 4, 2024 12:29
…mb [MDB IGNORE] (#3517)

* Fixed quirk conflict between transhumanist and prosthetic limb (#84325)

## About The Pull Request

Transhumanist and prosthetic limb no longer conflict. If you pick the
same limb for both it uses the weaker prosthetic (dumbass)

Made the name for prosthetic limb global list more intelligible

## Why It's Good For The Game

> Transhumanist and prosthetic limb no longer conflict. If you pick the
same limb for both it uses the weaker prosthetic (dumbass)

I wanted to RP a guy with a robotic voicebox and prosthetic limb but the
game didn't let me, which I thought was pretty lame! Since the root
issue is likely that both can have the same limb which ends up as Free
Points as transhuman takes priority, I just added a check to ensure that
can't happen and is overridden by the negative instead. Any
transhumanist mood point benefits are made up for by the bad limb.

> Made the name for prosthetic limb global list more intelligible

It was bad

## Changelog

:cl:
qol: Transhumanist and prosthetic limb no longer conflict. If you pick
the same limb for both it uses the weaker prosthetic (dumbass)
code: Made the name for prosthetic limb global list more intelligible

/:cl:

* Fixed quirk conflict between transhumanist and prosthetic limb

---------

Co-authored-by: carlarctg <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants