wip

ArkEcosystem · Dec 19, 2024 · 95238fa · 95238fa
1 parent 9c5dc9d
commit 95238fa
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/src/Transactions/Builder/MultipaymentBuilder.php b/src/Transactions/Builder/MultipaymentBuilder.php
@@ -22,7 +22,6 @@ public function __construct(?array $data = null)
 
     public function pay(string $address, string $amount): self
     {
-        // TODO: validate amount and address?
         $this->transaction->data['pay'][0][] = $address;
         $this->transaction->data['pay'][1][] = $amount;
 

diff --git a/src/Transactions/Types/ValidatorRegistration.php b/src/Transactions/Types/ValidatorRegistration.php
@@ -5,6 +5,7 @@
 namespace ArkEcosystem\Crypto\Transactions\Types;
 
 use ArkEcosystem\Crypto\Enums\AbiFunction;
+use ArkEcosystem\Crypto\Helpers;
 use ArkEcosystem\Crypto\Utils\AbiEncoder;
 
 class ValidatorRegistration extends AbstractTransaction
@@ -14,7 +15,7 @@ public function __construct(?array $data = [])
         $payload = $this->decodePayload($data);
 
         if ($payload !== null) {
-            $data['validatorPublicKey'] = ltrim($payload['args'][0], '0x');
+            $data['validatorPublicKey'] = Helpers::removeLeadingHexZero($payload['args'][0]);
         }
 
         parent::__construct($data);

diff --git a/tests/Unit/Transactions/Builder/MultipaymentBuilderTest.php b/tests/Unit/Transactions/Builder/MultipaymentBuilderTest.php
@@ -53,12 +53,6 @@ public function it_should_handle_single_recipient()
         $this->assertTrue($builder->verify());
     }
 
-    // /** @test */
-    // public function it_should_handle_sending_to_self()
-    // {
-
-    // }
-
     /** @test */
     public function it_should_handle_empty_payment()
     {