refactor(crypto-transaction): use RLP for serialization #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sebastijankuzner
changed the title
oXtxNt9U
requested changes
Dec 16, 2024
| @@ -31,12 +31,12 @@ export const transactionBaseSchema: SchemaObject = { | |||
| network: { $ref: "networkByte" }, | |||
|
|
|||
| nonce: { bignumber: { minimum: 0 } }, | |||
|
|
|||
| r: { type: "string" }, // TODO: prefixed hex | |||
There was a problem hiding this comment.
limit length (64 or 65 with prefix)
|
|
||
| if (!signature || !senderPublicKey) { | ||
| if (!v || !r || !s || !senderPublicKey) { |
There was a problem hiding this comment.
If v can be 0 then this also evaluates to false. Double check
There was a problem hiding this comment.
I am using 27 & 28 values. 27 => false, 28 => true.
| @@ -66,4 +67,75 @@ export const prepareSandbox = async (context) => { | |||
| context.sandbox.app.bind(Identifiers.Cryptography.Block.Deserializer).to(Deserializer); | |||
| context.sandbox.app.bind(Identifiers.Cryptography.Block.IDFactory).to(IDFactory); | |||
| context.sandbox.app.bind(Identifiers.Cryptography.Block.Factory).to(BlockFactory); | |||
|
|
|||
| const builder = context.sandbox.app.resolve(EvmCallBuilder); | |||
There was a problem hiding this comment.
Code below just for debugging? (if so, can be removed)
| @@ -120,18 +120,18 @@ describe<{ | |||
| assert.string(block.serialized); | |||
| }); | |||
|
|
|||
| it("#fromData - should create a block with transactions instance from an object", async (context) => { | |||
| const block = await context.factory.fromData(blockDataWithTransactions); | |||
| it.skip("#fromData - should create a block with transactions instance from an object", async (context) => { | |||
There was a problem hiding this comment.
All tests should be fixed instead of skipped (also remove .only)
| @@ -270,7 +270,8 @@ export class Sync implements Contracts.ApiSync.Service { | |||
| senderAddress: data.senderAddress, | |||
| senderPublicKey: data.senderPublicKey, | |||
| sequence: data.sequence as unknown as number, | |||
| signature: data.signature, | |||
| // signature: data.signature, | |||
There was a problem hiding this comment.
We can concatenate the r,s,v components
| @@ -273,7 +273,8 @@ export class Restore { | |||
| senderAddress: data.senderAddress, | |||
| senderPublicKey: data.senderPublicKey, | |||
| sequence: data.sequence as unknown as number, | |||
| signature: data.signature, | |||
| // signature: data.signature, | |||
There was a problem hiding this comment.
We can concatenate the r,s,v components
|
changing to draft to prevent accidental merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make transactions EVM compatible.
Checklist