Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): add UsernamesV1.sol contract #773

Merged
merged 28 commits into from
Nov 22, 2024
Merged

feat(contracts): add UsernamesV1.sol contract #773

merged 28 commits into from
Nov 22, 2024

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Nov 20, 2024 •
edited
Loading

Summary

Checklist

  • Tests (if necessary)
  • Ready to be merged

oXtxNt9U
oXtxNt9U requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@oXtxNt9U oXtxNt9U left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just small nits.

contracts/test/usernames/UsernamesV1.sol Outdated Show resolved Hide resolved
contracts/src/usernames/UsernamesV1.sol Outdated Show resolved Hide resolved
@sebastijankuzner sebastijankuzner marked this pull request as ready for review November 21, 2024 12:05
@sebastijankuzner sebastijankuzner merged commit e05a907 into develop Nov 22, 2024
14 of 15 checks passed
@sebastijankuzner sebastijankuzner deleted the feat/contracts/usernames branch November 22, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oXtxNt9U oXtxNt9U oXtxNt9U approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastijankuzner @oXtxNt9U