refactor(evm): improve estimate gas error handling (#881)

* return error instead of panicking when passing invalid gas params * pass error message to rpc error when tx is invalid * style: resolve style guide violations * update test
ArkEcosystem · Mar 10, 2025 · ead336e · ead336e
1 parent 6cbe176
commit ead336e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/packages/api-evm/source/actions/eth-estimate-gas.ts b/packages/api-evm/source/actions/eth-estimate-gas.ts
@@ -85,7 +85,9 @@ export class EthEstimateGasAction implements Contracts.Api.RPC.Action {
 			if (success) {
 				return `0x${gasUsed.toString(16)}`;
 			}
-		} catch {}
+		} catch (error) {
+			throw new Exceptions.RpcError(`execution reverted: ${error.message}`);
+		}
 
 		throw new Exceptions.RpcError("execution reverted");
 	}

diff --git a/packages/evm-service/source/instances/evm.test.ts b/packages/evm-service/source/instances/evm.test.ts
@@ -793,7 +793,7 @@ describe<{
 					blockContext: { ...blockContext, commitKey: { height: BigInt(0), round: BigInt(0) } },
 					...deployConfig,
 				}),
-			"Panic in async function",
+			"transaction validation error: lack of funds (0) for max fee (2)",
 		);
 	});
 

diff --git a/packages/evm/bindings/src/lib.rs b/packages/evm/bindings/src/lib.rs
@@ -656,14 +656,11 @@ impl EvmInner {
                         match err {
                             revm::primitives::InvalidTransaction::CallGasCostMoreThanGasLimit
                             | revm::primitives::InvalidTransaction::NonceTooHigh { .. }
-                            | revm::primitives::InvalidTransaction::NonceTooLow { .. } => {
-                                return Err(EVMError::Transaction(err));
-                            }
-                            revm::primitives::InvalidTransaction::LackOfFundForMaxFee {
-                                fee,
-                                balance,
+                            | revm::primitives::InvalidTransaction::NonceTooLow { .. }
+                            | revm::primitives::InvalidTransaction::LackOfFundForMaxFee {
+                                ..
                             } => {
-                                todo!("lack of funds (fee={} balance={})", fee, balance);
+                                return Err(EVMError::Transaction(err));
                             }
                             // revm::primitives::InvalidTransaction::PriorityFeeGreaterThanMaxFee => todo!(),
                             // revm::primitives::InvalidTransaction::GasPriceLessThanBasefee => todo!(),