Created secure ESP32 example #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secure ESP32-compatible Pushover example
commented out .setInsercure() as it's not working with ESP32.
soundstorm
requested changes
Jun 28, 2020
| @@ -44,7 +44,7 @@ void Pushover::setHTML(boolean html) { | |||
| boolean Pushover::send(void) { | |||
| WiFiClientSecure client; | |||
| if (_unsafe) { | |||
| client.setInsecure(); | |||
| //client.setInsecure(); //not working with ESP32 | |||
There was a problem hiding this comment.
Why are you commenting out this? Please use preprocessor instructions.
|
|
||
| const char* ssid = ""; // your network SSID (name of wifi network) | ||
| const char* password = ""; // your network password | ||
| const char* userToken = ""; |
There was a problem hiding this comment.
If using extra spaces, please align all evenly.
| #include <WiFiClientSecure.h> | ||
| #include <Pushover.h> | ||
|
|
||
| const char* ssid = ""; // your network SSID (name of wifi network) |
Comment on lines
+41
to
+50
| Serial.print("Attempting to connect to SSID: "); | ||
| Serial.println(ssid); | ||
| WiFi.begin(ssid, password); | ||
|
|
||
| // attempt to connect to Wifi network: | ||
| while (WiFi.status() != WL_CONNECTED) { | ||
| Serial.print("."); | ||
| // wait 1 second for re-trying | ||
| delay(1000); | ||
| } |
| while (WiFi.status() != WL_CONNECTED) delay(50); | ||
| Serial.println("Connected"); | ||
| client.setCACert(test_root_ca); | ||
| Pushover po = Pushover(appToken,userToken, SAFE); |
There was a problem hiding this comment.
SAFE can be left out, as it's the default value.
|
Sorry for the low quality, just wanted to send a working ssl example for possible inclusion and there isn't a great mechanism for just contacting an author. Feel free to reject. Just wanted to put the code out there in case someone found it useful. |
|
You may improve it by using |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a secure ESP32 example. I had to comment out the .setInsecure method as it doesn't appear in the ESP32 version of WiFiClientSecure