fix: "division by zero" when searching for collections to nominate (#658

)
ArdentHQ · Feb 8, 2024 · b272719 · b272719
1 parent 2359a83
commit b272719
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/Http/Controllers/Api/VotableCollectionController.php b/app/Http/Controllers/Api/VotableCollectionController.php
@@ -56,8 +56,8 @@ public function index(FilterableCollectionRequest $request): JsonResponse
      */
     private function getVotedCollection(User $user, EloquentCollection $collections): ?VotableCollectionData
     {
-        $collection = Collection::votable()
-                                ->withCount(['votes' => fn ($q) => $q->inCurrentMonth()])
+        $collection = Collection::query()
+                                ->withCount(['nfts', 'votes' => fn ($q) => $q->inCurrentMonth()])
                                 ->with('network.nativeToken')
                                 ->votedByUserInCurrentMonth($user)
                                 ->first();

diff --git a/app/Models/Collection.php b/app/Models/Collection.php
@@ -631,12 +631,13 @@ public function scopeAddFloorPriceChange(Builder $query): Builder
                 SELECT
                     (AVG(case when fp1.retrieved_at >= CURRENT_DATE then fp1.floor_price end) -
                     AVG(case when fp1.retrieved_at >= CURRENT_DATE - INTERVAL '1 DAY' AND fp1.retrieved_at < CURRENT_DATE then fp1.floor_price end)) /
-                    AVG(case when fp1.retrieved_at >= CURRENT_DATE - INTERVAL '1 DAY' AND fp1.retrieved_at < CURRENT_DATE then fp1.floor_price end) * 100
+                    NULLIF(AVG(case when fp1.retrieved_at >= CURRENT_DATE - INTERVAL '1 DAY' AND fp1.retrieved_at < CURRENT_DATE then fp1.floor_price end) * 100, 0)
                 FROM
                     floor_price_history fp1
                 WHERE
                     fp1.collection_id = collections.id AND
-                    fp1.retrieved_at >= CURRENT_DATE - INTERVAL '1 DAY') AS price_change_24h
+                    fp1.retrieved_at >= CURRENT_DATE - INTERVAL '1 DAY'
+                ) AS price_change_24h
             ")
         );
     }