-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: arkconnect navbar button #799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally the hasExtension()
condition doesnt seem to work for me (i removed that condition to test this PR)
Tried to install the latest version of the arkconnect extension on chrome+mac and window.arkconnect
is undefined, same happens if I run the develop version of the plugin, not sure if I missing something
update:wasnt using https
…rkscan into feat/arkconnect-navbar-button
…rkscan into feat/arkconnect-navbar-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design is good now, but now the button is always disabled
Probably because of this line is never setting isLoading to false
Also in my case I have arkconnect, maybe when that function runs the window.arkconnect is not set yet
…rkscan into feat/arkconnect-navbar-button
working now @alexbarnsley |
Summary
https://app.clickup.com/t/86drwqqf8
requires ArkEcosystem/laravel-foundation#613
Todo:
To test:
ARKCONNECT_ENABLED=true
to.env
https
instance of explorer. For valet, you can usevalet secure
to force https - usevalet unsecure
to change it back tohttp
Checklist