Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework RequestException temporarily as a less breaking change #130

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

Archomeda
Copy link
Owner

This is a less breaking change that can function as a transition period for the full exception handling rework. Version 2.0 is still a bit off, and this will at least ease the pain of handling Gw2Sharp exceptions via the non-generic RequestException as it was meant to be in the first place, but somehow didn't end up how it was supposed to.

It's a less than ideal change due to the Response property that's now marked as new in the generic RequestException<T>, which means that the non-generic RequestException.Response won't be set (and is hidden) when RequestException<T>.Response is used instead. See the C# documentation.

See #96 for the full change that will happen in v2.0, which includes a deletion of the generic variant of RequestException<T>.

@Archomeda Archomeda added Type: Bug Something isn't working Area: Web API v2 Related to the v2 web API labels Mar 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@Archomeda Archomeda merged commit 8bd1949 into master Jun 3, 2023
@Archomeda Archomeda deleted the refactor/temp-request-exception-workaround branch June 3, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant