Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor web API exceptions #104

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Refactor web API exceptions #104

merged 2 commits into from
Sep 28, 2021

Conversation

Archomeda
Copy link
Owner

The generic typed exceptions have been entirely removed, making it easier to catch exceptions thrown from Gw2Sharp.

This is a breaking change, and is going to be effective starting from version 2.0.

Closes #96

@Archomeda Archomeda added Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features labels Sep 28, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@Archomeda Archomeda merged commit 9418e23 into 2.0 Sep 28, 2021
@Archomeda Archomeda deleted the refactor/web-exceptions branch September 28, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant