Lazy-load yt-dlp media players in card template#34
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
ef0d535 to
d80fdf1
Compare
|
Update: this note is superseded by maintainer feedback below. I removed the Claude/Anthropic missing-key skip behavior from this PR, per @pirate’s request. The Claude integration tests now keep their upstream behavior: they fail when That means this abx-plugins PR no longer attempts to clear the Claude failures visible on ArchiveBox/ArchiveBox#1819. Those failures are expected on contributor PR CI until the run is approved or a maintainer-side CI environment with credentials is used. |
e5ec88c to
1b71a75
Compare
|
I don't want to ever skip the claude tests, can you remove that skip case. It's fine if they're failing for contributor PRs until I approve the run. |
00503ac to
8d30c12
Compare
|
Done in Local verification after the change: |
779a2ed to
41878e4
Compare
c75ac3b to
22731f9
Compare
Companion to ArchiveBox/ArchiveBox#1819.
Moves the yt-dlp media player behavior into the yt-dlp plugin card template, where plugin-specific rendering belongs.
The card now:
hrefanddata-srcvalues so filenames with reserved characters still workAlso fixes Claude integration test behavior for public CI:
ANTHROPIC_API_KEYis absent instead of failing the PRCLAUDECODE_BINARYenv overrides are respected before hydrated binary defaultsVerification: