ref - Simplified collections

--- Type: ref Breaking: False Doc Required: False Part: 1/1
Aptivi · Feb 15, 2024 · 89022be · 89022be
1 parent 191e5df
commit 89022be
Show file tree

Hide file tree

Showing 14 changed files with 16 additions and 16 deletions.
diff --git a/public/Nitrocid.Addons/Nitrocid.Extras.Notes/Management/NoteManagement.cs b/public/Nitrocid.Addons/Nitrocid.Extras.Notes/Management/NoteManagement.cs
@@ -76,7 +76,7 @@ internal static void RemoveNotes() =>
         /// </summary>
         /// <returns>An array of note contents</returns>
         internal static string[] ListNotes() =>
-            notes.ToArray();
+            [.. notes];
 
         /// <summary>
         /// Saves all notes

diff --git a/public/Nitrocid/Drivers/Filesystem/BaseFilesystemDriver.cs b/public/Nitrocid/Drivers/Filesystem/BaseFilesystemDriver.cs
@@ -989,7 +989,7 @@ public virtual string GetNumberedFileName(string path, string fileName)
 
         /// <inheritdoc/>
         public virtual List<string> GetPathList() =>
-            PathLookupTools.PathsToLookup.Split(Convert.ToChar(PathLookupTools.PathLookupDelimiter)).ToList();
+            [.. PathLookupTools.PathsToLookup.Split(Convert.ToChar(PathLookupTools.PathLookupDelimiter))];
 
         /// <inheritdoc/>
         public string GetRandomFileName() =>

diff --git a/public/Nitrocid/Kernel/Debugging/DebugWriter.cs b/public/Nitrocid/Kernel/Debugging/DebugWriter.cs
@@ -53,7 +53,7 @@ public static class DebugWriter
         /// Debug stack trace list
         /// </summary>
         public static string[] DebugStackTraces =>
-            debugStackTraces.ToArray();
+            [.. debugStackTraces];
 
         /// <summary>
         /// Censor private information that may be printed to the debug logs.

diff --git a/public/Nitrocid/Kernel/Debugging/RemoteDebug/RemoteDebugDeviceInfo.cs b/public/Nitrocid/Kernel/Debugging/RemoteDebug/RemoteDebugDeviceInfo.cs
@@ -67,7 +67,7 @@ public class RemoteDebugDeviceInfo
         /// </summary>
         [JsonIgnore]
         public string[] ChatHistory =>
-            chatHistory.ToArray();
+            [.. chatHistory];
 
         [JsonConstructor]
         internal RemoteDebugDeviceInfo()

diff --git a/public/Nitrocid/Kernel/Debugging/RemoteDebug/RemoteDebugTools.cs b/public/Nitrocid/Kernel/Debugging/RemoteDebug/RemoteDebugTools.cs
@@ -303,7 +303,7 @@ public static string[] ListDeviceNames() =>
         /// Lists all devices and puts them into an array
         /// </summary>
         public static RemoteDebugDeviceInfo[] ListDevices() =>
-            remoteDebugDevices.ToArray();
+            [.. remoteDebugDevices];
 
         /// <summary>
         /// Gets a device by IP address

diff --git a/public/Nitrocid/Misc/Interactives/FilesSelectorCli.cs b/public/Nitrocid/Misc/Interactives/FilesSelectorCli.cs
@@ -209,7 +209,7 @@ public override string GetEntryFromItem(object item)
         /// Selected files. If not selected yet and bailed earlier, this list is empty.
         /// </summary>
         public string[] SelectedFiles =>
-            selectedFiles.ToArray();
+            [.. selectedFiles];
 
         private static void SelectOrGoTo(FileSystemEntry currentFileSystemEntry)
         {

diff --git a/public/Nitrocid/Misc/Interactives/FoldersSelectorCli.cs b/public/Nitrocid/Misc/Interactives/FoldersSelectorCli.cs
@@ -211,7 +211,7 @@ public override string GetEntryFromItem(object item)
         /// Selected files. If not selected yet and bailed earlier, this list is empty.
         /// </summary>
         public string[] SelectedFolders =>
-            selectedFolders.ToArray();
+            [.. selectedFolders];
 
         private static void Select(FileSystemEntry currentFileSystemEntry)
         {

diff --git a/public/Nitrocid/Misc/Splash/SplashReport.cs b/public/Nitrocid/Misc/Splash/SplashReport.cs
@@ -72,7 +72,7 @@ public static class SplashReport
         /// Log buffer of the boot process
         /// </summary>
         public static string[] LogBuffer =>
-            logBuffer.ToArray();
+            [.. logBuffer];
 
         /// <summary>
         /// Reports the progress for the splash screen while the kernel is booting.

diff --git a/public/Nitrocid/Modifications/ModManager.cs b/public/Nitrocid/Modifications/ModManager.cs
@@ -369,7 +369,7 @@ public static void RemoveModFromBlacklist(string ModFilename)
         /// <summary>
         /// Gets the blacklisted mods list
         /// </summary>
-        public static List<string> GetBlacklistedMods() => BlacklistedModsString.Split(';').ToList();
+        public static List<string> GetBlacklistedMods() => [.. BlacklistedModsString.Split(';')];
 
         /// <summary>
         /// Installs the mod DLL or single code file to the mod directory

diff --git a/public/Nitrocid/Network/SpeedDial/SpeedDialTools.cs b/public/Nitrocid/Network/SpeedDial/SpeedDialTools.cs
@@ -186,7 +186,7 @@ public static bool TryAddEntryToSpeedDial(string Address, int Port, string Speed
         /// </summary>
         /// <returns>A list</returns>
         public static SpeedDialEntry[] ListSpeedDialEntries() =>
-            speedDialEntries.ToArray();
+            [.. speedDialEntries];
 
         /// <summary>
         /// Lists all speed dial entries by type

diff --git a/public/Nitrocid/Shell/ShellBase/Arguments/CommandArgumentPart.cs b/public/Nitrocid/Shell/ShellBase/Arguments/CommandArgumentPart.cs
@@ -106,7 +106,7 @@ public CommandArgumentPart(bool argumentRequired, string argumentExpression, Fun
                 if (!done && argumentExpression.Contains('/'))
                 {
                     string[] expressions = argumentExpression.Split('/');
-                    autoCompleter = (_) => expressions.ToArray();
+                    autoCompleter = (_) => [.. expressions];
                     done = true;
                 }
             }

diff --git a/public/Nitrocid/Shell/Shells/Admin/AdminShellInfo.cs b/public/Nitrocid/Shell/Shells/Admin/AdminShellInfo.cs
@@ -46,7 +46,7 @@ internal class AdminShellInfo : BaseShellInfo, IShellInfo
                     {
                         new CommandArgumentPart(false, "argument", new CommandArgumentPartOptions()
                         {
-                            AutoCompleter = (_) => ArgumentParse.AvailableCMDLineArgs.Keys.ToArray()
+                            AutoCompleter = (_) => [.. ArgumentParse.AvailableCMDLineArgs.Keys]
                         })
                     })
                 ], new ArgHelpCommand(), CommandFlags.Wrappable | CommandFlags.RedirectionSupported),

diff --git a/public/Nitrocid/Shell/Shells/Debug/DebugShellInfo.cs b/public/Nitrocid/Shell/Shells/Debug/DebugShellInfo.cs
@@ -75,7 +75,7 @@ internal class DebugShellInfo : BaseShellInfo, IShellInfo
                     {
                         new CommandArgumentPart(true, "field", new CommandArgumentPartOptions()
                         {
-                            AutoCompleter = (_) => FieldManager.GetAllFieldsNoEvaluation().Keys.ToArray(),
+                            AutoCompleter = (_) => [.. FieldManager.GetAllFieldsNoEvaluation().Keys],
                         })
                     }, true)
                 ], new GetFieldValueCommand()),
@@ -86,7 +86,7 @@ internal class DebugShellInfo : BaseShellInfo, IShellInfo
                     {
                         new CommandArgumentPart(true, "property", new CommandArgumentPartOptions()
                         {
-                            AutoCompleter = (_) => PropertyManager.GetAllPropertiesNoEvaluation().Keys.ToArray(),
+                            AutoCompleter = (_) => [.. PropertyManager.GetAllPropertiesNoEvaluation().Keys],
                         })
                     }, true)
                 ], new GetPropertyValueCommand()),

diff --git a/public/Nitrocid/Shell/Shells/UESH/UESHShellInfo.cs b/public/Nitrocid/Shell/Shells/UESH/UESHShellInfo.cs
@@ -282,7 +282,7 @@ internal class UESHShellInfo : BaseShellInfo, IShellInfo
                     {
                         new CommandArgumentPart(true, "oldUserName", new CommandArgumentPartOptions()
                         {
-                            AutoCompleter = (_) => UserManagement.ListAllUsers().ToArray()
+                            AutoCompleter = (_) => [.. UserManagement.ListAllUsers()]
                         }),
                         new CommandArgumentPart(true, "newUserName"),
                     })
@@ -798,7 +798,7 @@ internal class UESHShellInfo : BaseShellInfo, IShellInfo
                         new CommandArgumentPart(true, "reload/load/unload"),
                         new CommandArgumentPart(true, "customlanguagename", new CommandArgumentPartOptions()
                         {
-                            AutoCompleter = (_) => LanguageManager.CustomLanguages.Keys.ToArray()
+                            AutoCompleter = (_) => [.. LanguageManager.CustomLanguages.Keys]
                         }),
                     }),
                     new CommandArgumentInfo(new[]