Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contacts.ts #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Contacts.ts #44

wants to merge 1 commit into from

Conversation

Hiroki111
Copy link

TypeScript complains that deleteContact isn't returning a string value via inResolve.

TypeScript complains that `deleteContact` isn't returning a string value via `inResolve`.
@fzammetti
Copy link
Collaborator

Hi! Thanks very much for the contribution! I'd like to merge it, but I wonder if you could make just one minor change before I do: could you please add a comment right above the line mentioning that this is a change from the text in the book and why it's changed?

The concern I have is that if I just accept it outright, the code in the repo will diverge from the code shown in the book, and that will likely lead to confusion for readers (it's a unique concern with code from books versus just code that exists on its own). Adding a comment would provide the reader pertinent information if/when they see the difference.

Thanks again,
Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants