Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Appsflyer #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Modernize Appsflyer #31

wants to merge 3 commits into from

Conversation

albilaga
Copy link

@albilaga albilaga commented Dec 5, 2024

  • Update to use .net 8 as .net 6 is already out of support
  • Update project sdk to use Microsoft.NET.SDK
  • Include .snupkg so there will be symbols uploaded.
  • Remove obsolete xamarin.android samples

@albilaga
Copy link
Author

albilaga commented Dec 5, 2024

Hi @andr-ggn need suggestion on this. I create this PR mainly so appsflyer can also upload symbols so it can be traced pretty easily like in Sentry or other 3rd parties. But when trying this, I saw that this is still using legacy targets which is already not supported by Microsoft anymore so I also decided to update it using .net 8. Let. me know if you want to keep the old behavior. I also decided to not updating any version because I am not sure as well. Thank you

@Dani-Koza-AF
Copy link
Contributor

@albilaga Hey there!
We still have users that need the support for legacy Xamarin SDK.
In the near future we plan to ditch the multi‐targeting approach (Xamarin is deprecated) and unify it under the most updated LTS .NET as it should be.
Cheers.

@albilaga
Copy link
Author

@Dani-Koza-AF any plans on when is it and maybe I can help? Because with .NET 9 and FullAOT we need library that support full AOT as well (not really affecting android, as iOS only now that have full AOT support) but if we can keep it updated then it will be better

What I did with this specially is to include .snupkg into nuget so when there is crash from lib it will detected from crashlytics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants