Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: add trivial mmap failure check #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mischief
Copy link

No description provided.

Copy link

Build for testing:
artifacts x86_64
artifacts i686
artifacts armhf
artifacts aarch64
Use at your own risk.

Copy link

github-actions bot commented Jan 1, 2025

Build for testing:
artifacts x86_64
artifacts i686
artifacts armhf
artifacts aarch64
Use at your own risk.

Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but in theory, you'd have to add additional checks for open, close etc.

@mischief
Copy link
Author

mischief commented Jan 1, 2025

Looks good, but in theory, you'd have to add additional checks for open, close etc.

i could if you wish, but i thought the mmap was a bit more hazardous since it will likely segfault on failure rather than just give an error when it fails due to the subsequent array access into the pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants