Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cut collapsed table cell won't crash the editor #963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saif-ellafi
Copy link

@saif-ellafi saif-ellafi commented Nov 7, 2024

Currently, calling a cut action on a table cell will completely crash the table editor. it leaves the document in a state where a table has no cells, rather then deleting it completely.

Not sure if this approach is the best, but gets the job done. Any ideas welcome.

Warning: This won't retroactively fix editor states where the Document has already been broken prior to this patch.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (e7d9560) to head (b70028a).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   72.07%   72.23%   +0.16%     
==========================================
  Files         318      318              
  Lines       15074    15106      +32     
==========================================
+ Hits        10864    10912      +48     
+ Misses       4210     4194      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant