Update endpoints to allow forest data posting and fetching #2
Conversation
Endpoints, DTOs updated with 'type' parameter, to specify what kind of reports is being created/fetched
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
At the very least, address the CodeQL issue pertaining to MongoDB filtering by following the instructions provided in the issue description.
Furthermore, I strongly suggest transforming the type into an enum and implementing validation through the ParseEnumPipe. Considering the potential conflicts with reserved keywords in certain languages, it would be appreciated if you could consider renaming the variable from "type" to something else (e.g. "category").
src/admin/admin.service.ts
Outdated
| @@ -22,8 +22,8 @@ export class AdminService { | |||
| private readonly reportRepository: ReportRepository, | |||
| ) {} | |||
|
|
|||
| async getAllReports(): Promise<FullReportDto[]> { | |||
| const reports = await this.reportRepository.getAllReports(); | |||
| async getAllReports(type: string): Promise<FullReportDto[]> { | |||
There was a problem hiding this comment.
The term "type" is a reserved keyword in certain programming languages, such as Python and Scala. While it is generally recommended to steer clear of using reserved keywords as variable names to prevent potential conflicts.
vycius
force-pushed
the
forest-data-integration
branch
from
ba73abc
to
cd2d0f5
Compare
vycius
force-pushed
the
forest-data-integration
branch
from
cd2d0f5
to
db429ba
Compare
| 0, | ||
| e.filter((stat: { _id: string }) => stat._id == 'nepasitvirtino')[0] | ||
| .count ?? 0, | ||
| ReportService.filterStatistics(e, 'gautas'), |
There was a problem hiding this comment.
Please note that this change appears unrelated to the current pull request. For future reference, it's best to create a new pull request specifically for this bug fix.
| private static filterStatistics(e: any, status: string): number { | ||
| return e.filter((stat: { _id: string }) => stat._id == status).length > 0 | ||
| ? e.filter((stat: { _id: string }) => stat._id == status)[0].count ?? 0 | ||
| : 0; |
There was a problem hiding this comment.
Let's keep it DRY. Also, consider utilizing Array.at (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at), which gracefully handles undefined values for non-existent array indices
Equal operator bug fix
Update status statistics logic
Endpoints, DTOs updated with 'type' parameter, to specify what kind of reports is being created/fetched