fix(deps): upgrade packaging #2557
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
previously approved these changes
Mar 20, 2025
antazoey
approved these changes
Mar 21, 2025
antazoey
reviewed
Mar 21, 2025
| @@ -94,7 +94,7 @@ | |||
| "cchecksum>=0.0.3,<1", | |||
| # Pandas peer-dep: Numpy 2.0 causes issues for some users. | |||
| "numpy<2", | |||
| "packaging>=23.0,<24", | |||
| "packaging>=24.2,<25", | |||
There was a problem hiding this comment.
We have to fix in some downstream plugins before this will succeed: https://github.com/ApeWorX/ape-hardhat/blob/main/setup.py#L81
There was a problem hiding this comment.
Actually... This is a bit of a circular dependency. The container depends on both core Ape and plugins. Plugins depend on core ape. This why I think recommened_plugins type flows don't make much sense.
The only solution to merge with with a failing solution and then update the plugin and then the next update of core ape will have it all fixed.
|
@fubuloubu can we merge this? ill fix the plugins |
Yes, sounds more complex than I expected, thank you for taking this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I guess
setuptoolsupgraded there pin and it screwed us:https://github.com/ApeWorX/ape/actions/runs/13958350355/job/39075553268
How I did it
How to verify it
Checklist