-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: local network process MGMT CLI #2545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, would this better unlock subprocess testing in CI? At least for the integration tests
Probably, as it gives you more control to start up any networks you need in the beginning.. Also, you can more easily connect to providers via PID, which I want to think of a better way to incorporate that in |
Why not have this be the default way that |
Maybe when using the |
But I agree - when using Also, the atexit handler is the what does call the disconnect, not exiting the context. |
Would certainly be a lot faster testing this way vs. how I am doing backtests now w/ anvil in ApeWorX/silverback#174 Currently takes 14 mins to run 2 mins of history, so that needs to come way down |
If I was you, I would already be managing the process and just connecting to it and calling |
In any case, this is not super related to this PR so shouldn't be blocking |
Testing demo: I made a config like this: foundry:
ethereum:
local:
uri: http://127.0.0.1:5001
node:
ethereum:
local:
uri: http://127.0.0.1:5000 And then these are some commands w/ output:
|
6575687
to
b50503c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just have some notes about killing process interface
Feedback addressed! thank you |
So now you do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super helpful, nice add
1c3ce82
What I did
Allows flows like this:
basically Ape now tracks the processes it has started and you can easily kill them all from the command line as well more easily background the processes in the same terminal session and w/o losing the PID
fixes: #2528
Also allows
For connecting to local nodes processes via PID.
Note: this process must have been started by Ape for this to work currently though.
How I did it
copied this from the
dfx
tool: https://github.com/dfinity/sdkHow to verify it
tbd
Checklist