feat: add --exclude-compiler flag to ape compile command #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Feb 7, 2025
src/ape_compile/_cli.py
Outdated
| @@ -42,6 +42,11 @@ def _include_dependencies_callback(ctx, param, value): | |||
| help="Also compile dependencies", | |||
| callback=_include_dependencies_callback, | |||
| ) | |||
| @click.option( | |||
There was a problem hiding this comment.
This may also be useful in the ape pm compile command. We could potentially add this to the ape.cli.options module so it can be re-used.
src/ape_compile/_cli.py
Outdated
| @@ -42,6 +42,11 @@ def _include_dependencies_callback(ctx, param, value): | |||
| help="Also compile dependencies", | |||
| callback=_include_dependencies_callback, | |||
| ) | |||
| @click.option( | |||
| "--exclude-compiler", | |||
| type=click.Choice(["solidity", "vyper"], case_sensitive=False), | |||
There was a problem hiding this comment.
This shouldn't be a click.Choice. There are more compilers besides solidity and vyper. With Ape's plugin system, there isn't a fixed number of compilers.
A normal str type is just find.
0xthedance
force-pushed
the
exclude_compiler
branch
from
f14b068 to
d51b037
Compare
antazoey
reviewed
Mar 21, 2025
| @@ -449,11 +449,15 @@ def _get_needs_compile(self, paths: Iterable[Union[Path, str]]) -> Iterable[Path | |||
| else: | |||
| yield path | |||
|
|
|||
| def _compile_contracts(self, paths: Iterable[Union[Path, str]]): | |||
| def _compile_contracts( | |||
| self, paths: Iterable[Union[Path, str]], exclude_compiler: Optional[str] = None | |||
There was a problem hiding this comment.
maybe this should be a list of compiler names
| return click.option( | ||
| "--exclude-compiler", | ||
| help="Exclude a specific compiler from the compilation process", | ||
| type=str, |
There was a problem hiding this comment.
we should do is_multiple=True here so multiple compilers can be excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add a new flag to the
ape compilecommand that allows to specify a compiler to be excluded from the compilation:fixes: #2259
How I did it
Before invoking compiler's
compilemethod , the code checks ifexclude-compilerparameter matches the current compiler. If it does, the method skips that compiler and moves to the next one.How to verify it
If you think is correct I could proceed with the tests.