fix: could not decode ABIs when missing leading zeroes #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/padding-issues-abi-decode
branch
from
c198e79 to
59011c1
Compare
bitwise-constructs
previously approved these changes
Dec 19, 2024
NotPeopling2day
previously approved these changes
Dec 19, 2024
not with strict=False, that is why im hopin my eth-abi PR goes through |
antazoey
dismissed stale reviews from NotPeopling2day and bitwise-constructs
via
66867d2
antazoey
force-pushed
the
fix/padding-issues-abi-decode
branch
from
66867d2 to
8842e07
Compare
bitwise-constructs
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
boa gives us log data that is not always padded with leading zeroes.
i dont see why i cant just pad it myself and move on...
NOTE: We won't need this if this merges instead: ethereum/eth-abi#240
How I did it
make a custom decoder for uint25
question: is this supposed to happen even when strict=False? ill ask the snake charmers...
How to verify it
see my test
Checklist