Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage modifier stat for status effects #10306

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MEEPofFaith
Copy link
Contributor

@MEEPofFaith MEEPofFaith commented Oct 31, 2024

Before:
20241030-201229-Mindustry

After:
20241030-202150-java
(Did the default UI scale change at some point? 75% scale in the custom build is much smaller than 75% scale in 146.)

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@way-zer
Copy link
Contributor

way-zer commented Oct 31, 2024

It seems confusing that for calculates multiple buffs.

+200% and +100% get 600%

@MEEPofFaith
Copy link
Contributor Author

??????

@way-zer
Copy link
Contributor

way-zer commented Oct 31, 2024

??????

The display mode has been changed to increase and decrease, rather than multiplier. When calculating multiple buffs, it may cause misunderstanding to those who do not understand.

For example, with +200% and +100% will get 600% instead +300%

@MEEPofFaith
Copy link
Contributor Author

So it should be a multiplier instead?
x3 and x2 will more accurately convey x6

@way-zer
Copy link
Contributor

way-zer commented Nov 2, 2024

So it should be a multiplier instead? x3 and x2 will more accurately convey x6

Yeah, maybe x[accet]300[]% and x[red]70[]%

(Did the default UI scale change at some point? 75% scale in the custom build is much smaller than 75% scale in 146.)

I think it might be because of the high-dpi problem. In BE, the game will use the actual resolution (more clear) instead of scaling by the OS

@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Nov 4, 2024

So it should be a multiplier instead? x3 and x2 will more accurately convey x6

Yeah, maybe x[accet]300[]% and x[red]70[]%

Now it actually lists a multiplier.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants