-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#246: Playlist update only introduce fields to change #289
Open
KristianLengyel
wants to merge
9
commits into
AntonioMrtz:master
Choose a base branch
from
KristianLengyel:feat/246-Playlist-Update-Fields-To-Change
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#246: Playlist update only introduce fields to change #289
KristianLengyel
wants to merge
9
commits into
AntonioMrtz:master
from
KristianLengyel:feat/246-Playlist-Update-Fields-To-Change
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional parameter type hints in api_test_playlist, and refactor update_playlist_metadata in base_user_repository and added tests in test__playlist
… adding helper functions and fixing Ruff errors
…ithub.com/KristianLengyel/SpotifyElectron into feat/246-Playlist-Update-Fields-To-Change
…ons and implementing early returns
… into feat/246-Playlist-Update-Fields-To-Change
AntonioMrtz
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request separates the song management logic into two new methods: one for adding songs and one for removing songs from playlists. Additionally, it refines the
update_playlist
method by renaming it toupdate_playlist_metadata
to enable selective field updates, ensuring only specified fields (new_name
,description
,photo
) are updated without requiring all fields to be sent.Commit type
feat
: indicates the addition of new functionality for managing song additions/removals and updating playlist metadata selectively.Issue
#246
Solution
The problem was resolved by implementing separate methods and endpoints for adding and removing songs from playlists, ensuring focused functionality. Additionally, the
update_playlist
method was renamed toupdate_playlist_metadata
, now only requiring fields that need updating. This change allows the frontend to update playlist details more efficiently, reducing redundant data handling.Proposed Changes
add_songs_to_playlist
method to add songs to a playlist.remove_songs_from_playlist
method to remove songs from a playlist.update_playlist
toupdate_playlist_metadata
, enabling updates to only specified fields (new_name
,description
,photo
).update_playlist_metadata
functionality.Potential Impact
These changes streamline data transfer by minimizing the fields required for updates and isolating song management. However, any existing calls to the previous
update_playlist
method may need adjustment to align with the renamed method and modified endpoint behavior.Screenshots
(No screenshots needed for backend changes)
Additional Tasks
Assigned
@AntonioMrtz