validation and a test for it

Anthropohedron · Apr 4, 2015 · 6b45897 · 6b45897
1 parent d1e92a1
commit 6b45897
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/matcher.js b/lib/matcher.js
@@ -150,6 +150,9 @@ function createPattern(pattern) {
 }
 
 function Matcher(patterns) {
+  if (!(patterns && patterns.length)) {
+    throw new Error("No patterns provided to Matcher");
+  }
   this.patterns = patterns.map(createPattern);
 }
 

diff --git a/test/test-matcher.js b/test/test-matcher.js
@@ -1,6 +1,6 @@
 var Matcher = require("./matcher").Matcher;
 
-exports["test create path matcher"] = function(assert) {
+exports["test create matcher"] = function(assert) {
   var patterns = [
     "TAG:^Content-Type: image/",
     "NO-RESPONSE-TAG:^User-Agent: .*Internet",
@@ -15,4 +15,13 @@ exports["test create path matcher"] = function(assert) {
       patterns.length, "Correct number of patterns");
 };
 
+exports["test create match no patterns"] = function(assert) {
+  assert.throws(function() {
+    new Matcher();
+  }, /no patterns/i, "No arguments to Matcher constructor");
+  assert.throws(function() {
+    new Matcher([]);
+  }, /no patterns/i, "Empty array passed to Matcher constructor");
+}
+
 require("sdk/test").run(exports);