Better handling of cells that contain string 'nbdev_export(' #1490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you just happen to include string
nbdev_export(
in your code cell, the whole cell will be silently ignored bynbdev_prepare
,nbdev_test
,nbdev_proc_nbs
andnbdev_preview
. If this cell happens to contain code that is exported or rendered in docs, it would result in the corresponding command failing with hard to decipher error.I have removed the corresponding check from the nbdev code. I am not sure we need it, but I can make a version of this pull request that handles that more gracefully by injecting monkey patching code into notebooks, something like this:
I imagine the check was there to prevent infinite loops of
nbdev_prepare
calling itself, but this doesn't happen because the check is fornbdev_export
and not fornbdev_prepare
.