allow changing camera orientation and crop #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cool mod! I'd want a global boolean variable to switch on/off support for orientation values and to include logic for setting safe, default values if the layout variables are unset (before merging these changes). |
Author
|
Done |
Author
|
Also added support for cropping. |
Adding missing $camera_crop variable to the repair part and changing the $camera_orientation variable to work like in the startup part
This reverts commit 3692d16.
Fix missing variable
nohn
changed the title
|
@Anonymousdog thoughts on merging this pr? |
coltenkrauter
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.