Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to youtube extractor #1923

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Add warning to youtube extractor #1923

merged 3 commits into from
Jul 20, 2024

Conversation

retrouser955
Copy link
Collaborator

Changes

Adds a warning to YouTube extractor via process.emitWarning(), warning the user of some instability nature of Youtube Extractor and recommending discord-player-youtubei

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-player-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 1:32pm

Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably document this as well, and is this extractor listed in showcase?

@retrouser955
Copy link
Collaborator Author

Yes definitely. One slight problem. I have no idea how to modify the documentation. I'll try to tweak some settings and hope it works.

README.md Outdated Show resolved Hide resolved
apps/website/src/data/showcase.ts Outdated Show resolved Hide resolved
apps/website/src/pages/guide/_guides/welcome/welcome.mdx Outdated Show resolved Hide resolved
packages/extractor/src/extractors/YoutubeExtractor.ts Outdated Show resolved Hide resolved
@retrouser955
Copy link
Collaborator Author

Sure! I'm a bit busy right now. I will add in a while. Which GitHub issue though?

@twlite twlite merged commit 5d2c517 into Androz2091:stable Jul 20, 2024
3 checks passed
@retrouser955 retrouser955 deleted the stable branch July 20, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants