Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basically added two numbers #33

Closed
wants to merge 4 commits into from
Closed

Conversation

trbljump
Copy link

@trbljump trbljump commented Nov 8, 2023

No description provided.

Copy link

what-the-diff bot commented Nov 8, 2023

PR Summary

  • Enhanced Code of Conduct
    The CODE_OF_CONDUCT.md file was updated with new guidelines. This is done in an effort to improve the community environment and ensure a harassment-free experience for all participants.

  • Updated Number List
    The numbers.txt file was modified to include the numbers 17 and 18. This update is for maintaining an updated and sequential list of numbers in the file.

@AndrewFeeney
Copy link
Owner

@trbljump Thanks so much for your contribution! It looks like you've put in a great deal of work here, tackling multiple issues with the codebase. I had a quick read through the commit history, and it was a wild ride. Unfortunately according to the contribution guidelines (https://github.com/AndrewFeeney/all-positive-integers-in-ascending-order/blob/main/CONTRIBUTING.md#how-many-are-allowed-per-pull-request) we have a strict rule of only one number per request. Otherwise the review process becomes burdensome. I also note that you have made a change to the code of conduct, which is another separate thing that we'd have to review on top of the two numbers.

If you would like to make some or all of these changes again in separate pull requests I'd be happy to take another look, but for now I'm going to have to close this PR in it's current state. Please don't take this is a personal attack or a comment on your skills!

Thanks again for contributing, and I do hope you resubmit another PR with this feedback in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants