Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to add 14 #29

Closed
wants to merge 1 commit into from
Closed

Conversation

szymon-rd
Copy link

Attempt to expand the database

@what-the-diff
Copy link

what-the-diff bot commented Mar 21, 2023

PR Summary

  • Removed unnecessary line Line 13 was removed
  • Added new line A new line with the number 14 was added at the end of the file

@szymon-rd
Copy link
Author

szymon-rd commented Mar 21, 2023

@AndrewFeeney I can't get it right, the tests are failing, can you help? I am new to this codebase.
image

@szymon-rd
Copy link
Author

szymon-rd commented Mar 21, 2023

It is alternative solution to #28, I think we have to discuss which one is better to go forward with (this one has tests failing but I think I can argue that there are some advantages that just need a little bit of work)

@AndrewFeeney
Copy link
Owner

With regret I am unable to merge this PR as another earlier one with a similar feature has just been merged. I can see that you poured a great deal of effort into this, and I appreciate it. If you would like to modify it and reopen it, I would gladly reconsider it.

@szymon-rd
Copy link
Author

@AndrewFeeney Was there any discussion on which design would be more fitting for this feature? I am disappointed that I was not included in the discussions or that the other solution was just chosen without considering the benefits of this one.

@AndrewFeeney
Copy link
Owner

If you feel that your implementation offers advantages I'm open to hearing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants