Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 in binary #20

Merged
merged 1 commit into from
Mar 2, 2023
Merged

add 2 in binary #20

merged 1 commit into from
Mar 2, 2023

Conversation

shanamatthews
Copy link
Contributor

@shanamatthews shanamatthews commented Mar 2, 2023

Ignore PR title, it's 10. Not 2 in binary, that would be obviously incorrect and inappropriate for this base 10 list of numbers.

@AndrewFeeney
Copy link
Owner

This is amazing work, thankyou @shanamatthews! I love the PR title, and in fact you raise a good point. I don't believe we've specified what base these integers are in, and that may cause some confusion!

@AndrewFeeney AndrewFeeney merged commit 85adb1a into AndrewFeeney:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants