Update numbers.txt #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the list of positive integers to include the next consecutive integer, three (3). Four (4) and five (5) were considered, but rejected due to the fact that they did not meet the consecutive criterion, and 2.5 was considered and rejected, as it is not an integer. Removed empty line at the end of the file to improve automated file readability.
bbeniamin
approved these changes
Feb 15, 2023
| @@ -1,2 +1,3 @@ | |||
| 1 | |||
| 2 | |||
| 3 | |||
There was a problem hiding this comment.
Should we add a pre-commit hook that removes new lines from the end of this file to prevent the new line from accidentally being added back with a future commit?
There was a problem hiding this comment.
Yes I think that's an excellent idea, I'll leave that in your capable hands.
|
Thanks for taking the time to put this PR together. I can see that you put a lot of thought into this, and I appreciate your attention to detail. Everything seems good and I can see no reason not to merge this. Progress! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the list of positive integers to include the next consecutive integer, three (3). Four (4) and five (5) were considered, but rejected due to the fact that they did not meet the consecutive criterion, and 2.5 was considered and rejected, as it is not an integer. Removed empty line at the end of the file to improve automated file readability.