Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 Star rating #665

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Add 5 Star rating #665

merged 3 commits into from
Jul 19, 2022

Conversation

sy-b
Copy link
Contributor

@sy-b sy-b commented Jun 29, 2022

resolves #105

RYDStarRatingPage


Credits:

Some code is stolen browed from Mads Stoumann's post. Also available on https://codepen.io/stoumann/pen/yLbYOdz

@cyrildtm
Copy link
Contributor

Just to make sure we aren't using any copyrighted "star icon" SVGs right?

@PickleNik
Copy link
Collaborator

wow finally somebody made it after i promised it 6 months ago and never spoke of it again
thank you 🙏🏼

@sy-b
Copy link
Contributor Author

sy-b commented Jun 29, 2022

Just to make sure we aren't using any copyrighted "star icon" SVGs right?


from: https://blog.codepen.io/documentation/licensing/

Public pens are automatically MIT licensed.

@sy-b
Copy link
Contributor Author

sy-b commented Jun 29, 2022

Some more feature suggestions:

  • Modify SVG

    • color
    • size
    • the SVG itself; custom svg (heart, rockets, etc)
  • Rating using the stars

    • optionally removing like & dislike button

@sy-b
Copy link
Contributor Author

sy-b commented Jun 29, 2022

@PickleNik
Another reminder ->
You have to update https://github.com/Anarios/return-youtube-dislike/projects/1

@Ione15
Copy link

Ione15 commented Jun 29, 2022

Add option to show only stars, only thumbs (default), or both

@Anarios Anarios changed the base branch from main to develop July 19, 2022 21:43
@Anarios Anarios merged commit 5dd6b0b into Anarios:develop Jul 19, 2022
@s5bug
Copy link

s5bug commented Jul 20, 2022

I'm running develop, and I see

  • no option to disable the stars
  • no option to enable a ratio bar

The ratio here (about 2%) is big enough to be visible on the ratio bar, yet can't be seen at all with the stars.

image

Why is this not configurable?

@sy-b
Copy link
Contributor Author

sy-b commented Jul 29, 2022

Why is this not configurable?

#698 adds it

@sy-b
Copy link
Contributor Author

sy-b commented Aug 1, 2022

The ratio here (about 2%) is big enough to be visible on the ratio bar, yet can't be seen at all with the stars.

Similar to the older YT UI, it is not supposed to be continuous.
I made it as a continuous bar to avoid programming fractional steps.

@sy-b sy-b deleted the starRating branch August 8, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add stars, just like in the old youtube
6 participants