Disallow properties with type array and no items #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a new check in row-meta-schema.json:152 which ensures that when a property has type "array", that "items" is also present.
Yrob
approved these changes
Jan 15, 2025
pstokkink
deleted the
disallow-properties-with-type-array-and-no-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: Schema validation should fail, with the accAfvalwijzer schema having two properties with type "array" and no "items". Locally this is already tested, but we should probably let the GH action do its work too. Perhaps by updating the schema prop in the faulty dataset schema?
row-meta-schema.jsonin each of those which checks if the "type" is "array". This alone is not enough, because when there is a "$ref", this check is also true, even when there is no "type" in the property, so this is also excluded.