Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a failing test for problem described in #146. No solution, yet. #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HenrikJoreteg
Copy link
Member

To help state the problem in the form of test.

@kamilogorek
Copy link
Contributor

I guess those tests won't work like we'd expect, because they'll give us false positive:

- this[coll] = new this._collections[coll](null, {parent: this});
+ this[coll] = new this._collections[coll](null, {parent: this, parse: true});

- this[child] = new this._children[child]({}, {parent: this});
+ this[child] = new this._children[child]({}, {parent: this, parse: true});

This change itself will fix the tests, but as we initialize those things as an empty, in the end nothing gets parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants