Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dataType updates #145

Closed
wants to merge 2 commits into from
Closed

Conversation

mmacaula
Copy link
Contributor

Fixes a bug vaguely referenced in #112 where listening to events could be messed up when using setOnce.

It also:

  • makes the set call be bound to this, which makes the call more powerful (this is also referenced in Suggestions for custom Datatypes  #112)
  • creates an onSet method for custom datatypes, which is designed to allow for initialization of custom datatypes after they pass all their tests (type check, setOnce, etc) but before events are called. Case here is for state type setting up child event bubbling.
  • updates for the state compare method to only do compare, child bubbling moved to new onSet method.

Currently does not update docs. #112 has been out there for awhile so I'm not sure how well this PR will be received. However, if I get interest from the core team, I'll update the docs to reflect the new changes. I'll even throw in some documentation for the state datatype (from #142 ). :)

@kamilogorek
Copy link
Contributor

Code looks fine, tests are in place. Thanks!

@mmacaula
Copy link
Contributor Author

#202 is the new home for this. Closing

@mmacaula mmacaula closed this Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants