Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save with wait:true, patch: true and custom serialize() method #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Save with wait:true, patch: true and custom serialize() method #64

wants to merge 5 commits into from

Commits on Nov 13, 2015

  1. fixes #52 

    When calling the `save()` method with `wait: true` and `patch: true`, the
current implmentation assumes a basic data structure and ignored the
structure generated by an overridden `serialize` method.

This fix invokes the `serialize()` method to ensure the user's data
structure is respected. In order for this to work with `PATCH`, we have to
inspect that structure to find where the attributes have been placed, and
then limit the properties of those object to only the ones changed.

This still makes some assumptions about the data structure (namely that all
attributes appear within a single object within the serialized structure),
but hopefully less restrictive ones than the current implementation.
    @bobholt
    bobholt committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    b94e6c9 View commit details
    Browse the repository at this point in the history

  2. make transformForPatch a function expression

    @bobholt
    bobholt committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    c421529 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary instantiation of constructor and fix transformForP… 

    …atch`
    @bobholt
    bobholt committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    71c0a5c View commit details
    Browse the repository at this point in the history

  4. serialize clonedModel in wait:true

    @bobholt
    bobholt committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    78d6098 View commit details
    Browse the repository at this point in the history

  5. return early if not an object in transformForPatch

    @bobholt
    bobholt committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    6e885a8 View commit details
    Browse the repository at this point in the history