Feature #107 And Added Bottom Footer #128
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
Please follow these guidelines for smooth collaboration:
- After completing a task, add your name and details to the Contributors Table/List.
- Attach relevant screenshots or videos of your contribution for transparency.
- Tasks are assigned on a first-come, first-served basis.
- Avoid spamming requests for already-assigned tasks.
- Respect the queue and wait for new tasks.
- Propose New Ideas: Discuss new features or suggestions in the "Ideas" channel before starting work.
|
@Amna-Hassan04 If you think this is alright, can you please merge the commit? Thank you once again. |
There was a problem hiding this comment.
Removed the Newsletter UI and the Script Code, according to the changes prescribed. Based on #107 and #108 (comment)
@Amna-Hassan04 Please let me know if it is alright now. Also please add the GSSoC and Hacktoberfest Labels. Thank you!
|
@sarinsanyal plz do make sure your pr uses the latest version of the project so i can merge |
|
I have resolved the conflict @Amna-Hassan04. Please check and let me know if it's alright. |
|
@sarinsanyal plz confirm that this PR is using the latest version of the project so i can merge. |
|
@sarinsanyal kindly update your pr to the latest version so that Amna can merge it. As the test already mentions that it has failed in having the pr up to date. Kindly do it asap. Otherwise everything looks good. |
|
@Amna-Hassan04 @zoobiasyed I have merged it once again. Please let me know if I can help you in any other way. Thank you. |
|
@Amna-Hassan04 I think it's good to go now. Thank you @sarinsanyal. |
On the basis of #107, I added the Bottom Footer and the Social Icons (with only GitHub and LinkedIn Working).
Also added a Newsletter Subscribing implementation and "Terms and Conditions", "Privacy Policy", etc. links that don't redirect to anywhere as of now.
At the end, I put in Acknowledgements for the creators and the Contributors.
Bottom.Navbar.and.Footer.mp4
@Amna-Hassan04 Please take a look at this video, and let me know if everything is alright. Thank you!