Fix use-after-free in task_wait_event::signal

Amanieu · Feb 1, 2020 · 172ca3f · 172ca3f · zerodefect · Feb 17, 2020
1 parent 2af276d
commit 172ca3f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/task_wait_event.h b/src/task_wait_event.h
@@ -97,8 +97,11 @@ class task_wait_event {
 	{
 		std::unique_lock<std::mutex> lock(mutex());
 		event_mask |= event;
-		lock.unlock();
+
+		// This must be done while holding the lock otherwise we may end up with
+		// a use-after-free due to a race with wait().
 		cond().notify_one();
+		lock.unlock();
 	}
 };