feat(slider): Add the ticks variant #1104
Open
+1,931
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkoOleksiyenko
force-pushed
the
slider-ticks
branch
2 times, most recently
from
31e16dd to
3aeb903
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 91.18% 91.15% -0.04%
==========================================
Files 99 99
Lines 2701 2759 +58
Branches 446 459 +13
==========================================
+ Hits 2463 2515 +52
- Misses 157 159 +2
- Partials 81 85 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MarkoOleksiyenko
force-pushed
the
slider-ticks
branch
9 times, most recently
from
77ba539 to
28b235f
Compare
divdavem
reviewed
Feb 19, 2025
core/src/components/slider/slider.ts
Outdated
| }, | ||
| styles: { | ||
| left: computed(() => (vertical$() ? null : percent(tickContext$().item.position))), | ||
| cursor: disabled$() ? 'disabled' : 'pointer', |
There was a problem hiding this comment.
Suggested change
| cursor: disabled$() ? 'disabled' : 'pointer', | |
| cursor: computed(() => disabled$() ? 'disabled' : 'pointer'), |
(cf #1114)
divdavem
reviewed
Feb 19, 2025
core/src/components/slider/slider.ts
Outdated
| @@ -857,6 +995,9 @@ export function createSlider(config?: PropsConfig<SliderProps>): SliderWidget { | |||
| 'au-slider-clickable-area': horizontal$, | |||
| 'au-slider-clickable-area-vertical': vertical$, | |||
| }, | |||
| styles: { | |||
| cursor: showTicks$() ? 'default' : 'pointer', | |||
There was a problem hiding this comment.
Suggested change
| cursor: showTicks$() ? 'default' : 'pointer', | |
| cursor: computed(() => showTicks$() ? 'default' : 'pointer'), |
(cf #1114)
MarkoOleksiyenko
force-pushed
the
slider-ticks
branch
from
28b235f to
672472e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.