added shutdown quarkus config to env #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pbhallam <[email protected]>
pbhallam
force-pushed
the
operator_wado_stow_2
branch
from
c37068e to
e8f41bc
Compare
Signed-off-by: pbhallam <[email protected]>
jeesmon
requested changes
Nov 5, 2022
| @@ -141,6 +141,14 @@ func GetStowServiceEnv(cr *v1alpha1.DicomwebIngestionService, existing []corev1. | |||
| Name: "EVENT_SOURCE", | |||
| Value: fmt.Sprintf("%s.%s.svc.cluster.local", GetStowServiceName(cr), cr.Namespace), | |||
| }, | |||
| { | |||
| Name: "QUARKUS_SHUTDOWN_TIMEOUT", | |||
| Value: "15S", | |||
There was a problem hiding this comment.
Why does operator needs to know about Quarkus. Operator should be unaware of implementation. Shouldn't this in application.properties of respective service (stow/wado)?
| @@ -132,6 +132,14 @@ func GetWadoServiceEnv(cr *v1alpha1.DicomwebIngestionService, existing []corev1. | |||
| Name: "QUERY_ENDPOINT", | |||
| Value: eventProcessorServiceEndpoint + "/query", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I did not add this , this was there before my change .
There was a problem hiding this comment.
I was talking about L135-L142 (same comment as previous comment I added for stow_service.go)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.