Fix the getVersionColumnForReplacingMergeTree() to support replicated tables properly #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturns only version_column from a replicated table definition (here `versionColumn = parameterArray[2].trim();`), but a is_deleted column migth be there too. 2. It's unnecessary to have separate if clauses for replicated and nonreplicated tables, we can union them.
|
Please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current logic the getVersionColumnForReplacingMergeTree() returns only version_column from a replicated table definition (here
versionColumn = parameterArray[2].trim();), but a is_deleted column migth be there too.It's unnecessary to have separate if clauses for replicated and nonreplicated tables, we can union them.