Add customizable adhoc SQL query for select adhoc values

[lunaticusgreen]

fix #330 , can be merged after #654

[Slach]

This is just not works
I tried to open any exists data source and got following error

Details
TypeError: Cannot read properties of undefined (reading 'split')
    at ConfigEditor (webpack-internal:///./views/ConfigEditor/ConfigEditor.tsx:79:13)
    at div
    at Et (http://localhost:3000/public/build/Connections.e0eda96e0598ac758584.js:48:2644)

[alon-cheq]

Hi 654 was merged, any update on this fix?

[Slach]

When open or create new Datasource i expected SQL query in adhoc field

[Slach]

[Slach]

Details
Error: Minified React error #310; visit https://reactjs.org/docs/error-decoder.html?invariant=310 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

    at QueryEditor (webpack-internal:///./views/QueryEditor/QueryEditor.tsx:81:13)

but QueryEditor.tsx contains only 77 lines, this is really weird

https://github.com/Altinity/clickhouse-grafana/blob/issue-330/src/views/QueryEditor/QueryEditor.tsx#L77

i run

npm run dev
npm run server

[Slach]

@antip00 instead of create tests for already tested macros, better will create test which cover works with adhoc macros and cover new functionality

[Slach]

@lunaticusgreen still get error
open http://localhost:3000/d/Bnh59Trnk/24-adhoc-2b-24-variable3a-text-formatting?from=now-6h&to=now&var-adhoc_variable=&var-split=service_name&editPanel=2

and remove NL (press )
and after reload adhoc stop works

[Slach]

Wrong fix
we don't have default data source name
remove clickhouse here

[Slach]

@lunaticusgreen e2e test failed

just add new dashboard -> add new visualization (default clickhouse-direct datasource)

got following error

An unexpected error happened
Details
TypeError: Cannot read properties of undefined (reading 'uid')

    at QueryEditor (webpack-internal:///./views/QueryEditor/QueryEditor.tsx:82:13)

[antip00]

If you change adhoc variable in panel, it do not changes in reformatted query
Screencast from 2024-11-22 15-46-12.webm

[lunaticusgreen]

@antip00 Hey, I think it's a bug with scenes, I've created bugreport, let's wait for grafanas response

[lunaticusgreen]

We probably will disable scenes for some time

[Slach]

@lunaticusgreen
it tried GF_FEATURE_TOGGLES_PUBLICDASHBOARDSSCENE: false in environment
and it reproduced
CLICKHOUSE_PLUGIN_VERSION=3.2.3 docker compose up -d grafana_external_install

http://localhost:3001/d/Bnh59Trnk/24-adhoc-2b-24-variable3a-text-formatting?editPanel=2

all works fine changing in adhoc control changed in Generated SQL

looks like we broke it in 2.3.4
CLICKHOUSE_PLUGIN_VERSION=3.2.4 docker compose up -d grafana_external_install

the same URL
http://localhost:3001/d/Bnh59Trnk/24-adhoc-2b-24-variable3a-text-formatting?editPanel=2

issue-330 branch little bit different behavior

git checkout issue-330
git pull origin issue-330
npm run dev
npm run server

panel in 3000 port
http://localhost:3000/d/Bnh59Trnk/24-adhoc-2b-24-variable3a-text-formatting?editPanel=2

GRAFANA_VERSION=10.4.3 docker compose up -d grafana
http://localhost:3000/d/Bnh59Trnk/24-adhoc-2b-24-variable3a-text-formatting?editPanel=2

this is definitely bug and shall be fixed