macros works only after 23.3+, #750

Altinity · Oct 10, 2023 · d0576f8 · d0576f8
1 parent b010edc
commit d0576f8
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/pkg/storage/object_disk/object_disk.go b/pkg/storage/object_disk/object_disk.go
@@ -293,7 +293,9 @@ func WriteMetadataToFile(metadata *Metadata, path string) error {
 
 func getObjectDisksCredentials(ctx context.Context, ch *clickhouse.ClickHouse) (map[string]ObjectStorageCredentials, error) {
 	credentials := make(map[string]ObjectStorageCredentials)
-	if version, err := ch.GetVersion(ctx); err != nil {
+	var version int
+	var err error
+	if version, err = ch.GetVersion(ctx); err != nil {
 		return nil, err
 	} else if version <= 20006000 {
 		return credentials, nil
@@ -320,8 +322,11 @@ func getObjectDisksCredentials(ctx context.Context, ch *clickhouse.ClickHouse) (
 				}
 				if endPointNode := d.SelectElement("endpoint"); endPointNode != nil {
 					creds.EndPoint = strings.Trim(endPointNode.InnerText(), "\r\n \t")
-					if creds.EndPoint, err = ch.ApplyMacros(ctx, creds.EndPoint); err != nil {
-						return nil, fmt.Errorf("%s -> /%s/storage_configuration/disks/%s apply macros to <endpoint> error: %v", configFile, root.Data, diskName, err)
+					// macros works only after 23.3+ https://github.com/Altinity/clickhouse-backup/issues/750
+					if version > 23003000 {
+						if creds.EndPoint, err = ch.ApplyMacros(ctx, creds.EndPoint); err != nil {
+							return nil, fmt.Errorf("%s -> /%s/storage_configuration/disks/%s apply macros to <endpoint> error: %v", configFile, root.Data, diskName, err)
+						}
 					}
 				} else {
 					return nil, fmt.Errorf("%s -> /%s/storage_configuration/disks/%s doesn't contains <endpoint>", configFile, root.Data, diskName)