Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] CI for JWT #515

Open
wants to merge 7 commits into
base: customizations/24.3.12
Choose a base branch
from
Open

Conversation

zvonand
Copy link
Collaborator

@zvonand zvonand commented Oct 30, 2024

Move JWT to its new home. I guess it will not go to 24.3 (it is a new feature), but some practice is always useful

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Move JWT to its new home

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@altinity-robot
Copy link
Collaborator

altinity-robot commented Oct 30, 2024

This is an automated comment for commit 7827d47 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success

@zvonand zvonand force-pushed the dev/jwt-with-ci branch 6 times, most recently from 84a6f61 to fe4a770 Compare November 3, 2024 23:34
@zvonand zvonand changed the title [Do not merge] learning CI for JWT [Do not merge] CI for JWT Nov 4, 2024
Fix fasttest

Fix fasttest

Fix

Update src/Client/ConnectionPool.h

Update src/Storages/StorageReplicatedMergeTree.cpp

Forbid creating a user with a name equal to `JWT_AUTHENTICAION_MARKER`

Cleanup

Pass `connection_host` by ref

Refactor with exceptions

Lint

Add new AuthenticationType to minimize conflicts

Fix fastest

Fix client failure

Add docs
Add aspell

Enable jwt-cpp in fasttest

Add test + some minor improvements

reduce unneeded possible clash points

fix build

fix typo in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants