Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.3 Backport of PR #65190: Support aliases in parametrized view function (only new analyzer) #500

Conversation

shiyer7474
Copy link

@shiyer7474 shiyer7474 commented Oct 11, 2024

Backport of ClickHouse#65190

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support aliases in parametrized view function (only new analyzer) (ClickHouse#65190 by @kssenii)

…n-param-view-function

Support aliases in parametrized view function (only new analyzer)
@altinity-robot
Copy link
Collaborator

altinity-robot commented Oct 11, 2024

This is an automated comment for commit 678a8e1 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success

@shiyer7474
Copy link
Author

Test test_distributed_inter_server_secret has failed in multiple integration test suites (unrelated to PR)

Test failures in Stateless test suites look similar to other backport PR : #494

Failure in 00147_global_in_aggregate_function in Stateful tests-tsan looks interesting, I am checking that.

@shiyer7474
Copy link
Author

Verified that 00147_global_in_aggregate_functionhas history of flakiness even right now :-

https://s3.amazonaws.com/clickhouse-test-reports/70451/6a203df9442e730808bf55657faaf478113a7bfd/stateful_tests__debug_.html

Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit 3ca5b07 into customizations/24.3.11 Oct 14, 2024
232 of 273 checks passed
@shiyer7474 shiyer7474 deleted the backports/24.3.11/65190_support_aliases_in_parameterized_view_function branch October 14, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants