Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.3 Add config for marking broken integration tests #472

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

strtgbb
Copy link
Collaborator

@strtgbb strtgbb commented Sep 25, 2024

CI Fix or Improvement

Add tests/integration/broken_tests.json which is used to selectively replace FAILED and ERROR statuses with BROKEN

Supersedes #469

@altinity-robot
Copy link
Collaborator

altinity-robot commented Sep 25, 2024

This is an automated comment for commit a77f135 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success

@Enmk Enmk changed the title Add config for marking broken integration tests 24.3 Add config for marking broken integration tests Sep 26, 2024
Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix mentioned issues.

Also, were you considering usage of @pytest.mark.xfail?
First of all: it is kind of standard to pytest, second it allows point-xfail and more....

https://docs.pytest.org/en/stable/how-to/skipping.html#xfail
https://docs.pytest.org/en/stable/reference/reference.html#pytest-mark-xfail-ref

@strtgbb
Copy link
Collaborator Author

strtgbb commented Sep 26, 2024

Also, were you considering usage of @pytest.mark.xfail? First of all: it is kind of standard to pytest, second it allows point-xfail and more....

Yes, pytest marks were considered, however that requires modifying test code and makes it less convenient to see a list of all broken tests.

@strtgbb
Copy link
Collaborator Author

strtgbb commented Sep 26, 2024

I haven't added a comment field yet because the error message seems clear enough. It will be trivial to add such when we require it.

@vzakaznikov
Copy link
Collaborator

vzakaznikov commented Sep 26, 2024

I haven't added a comment field yet because the error message seems clear enough. It will be trivial to add such when we require it.

No, let's add support for a comment field now. We don't want to revisit this functionality for such a small thing. I would call that field reason instead of a comment.

@strtgbb
Copy link
Collaborator Author

strtgbb commented Sep 26, 2024

let's add support for a comment field now.

Done. I don't know how to propagate the reason field upwards at this time, so it will just serve to help someone who is looking at the config file.

Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit d0d7b18 into customizations/24.3.9 Oct 1, 2024
239 of 272 checks passed
@strtgbb strtgbb deleted the override_broken_tests branch October 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants