-
-
Notifications
You must be signed in to change notification settings - Fork 15
Allow multiple block names in tutorial config for //line command #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, you just have to allow multiple blocks in the config (beginner-Tutorial.yml) and also change that config to include that. You don't have to keep backwards combatibility
Also Check if you can also solide the -id Field into that Array
You're absolutely right! I've switched to a config-based approach as you suggested. Changes made in commit 7d59454:
Now both Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
7d59454 to
db10c46
Compare
Zoriot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
a6be6dd to
e15df1b
Compare
Cinnazeyy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks good to me!
Maybe also add 35:0 to the base blocks, but thats quite an edge case anyways.
…ck names and improve readability
db10c46 to
dc84624
Compare
This change allows users to use the more intuitive
//line whitecommand in the beginner tutorial while maintaining the existing//line white_woolcommand through a config-based approach.Problem
The tutorial system previously only accepted the exact block name from the configuration (
//line white_wool), which is verbose and less intuitive than the commonly used short form//line white.Solution
Implemented a configuration-driven approach that allows multiple valid block names to be specified in the tutorial config file:
The system now:
base-blocksarray intutorial_beginner.ymlKey Features
//line tntare still properly rejected//line whiteand//line WHITEworkTechnical Changes
tutorial_beginner.ymlto usebase-blocksarray instead of singlebase-blockBASE_BLOCKSpath toTutorialPaths.javaBeginnerTutorial.Stage5to read and process the block listLineCmdEventTaskwith constructor overload for multiple block namesFixes #172.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.